Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is reported for dropping a materialized view. #53951

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is reported for dropping a materialized view. #53951

merged 1 commit into from
Dec 16, 2024
+18 −2

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Dec 15, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #53952

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zhangheihei zhangheihei requested a review from a team as a code owner December 15, 2024 15:18
@github-actions github-actions bot added the 3.4 label Dec 15, 2024
@github-actions github-actions bot added the 3.3 label Dec 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhangheihei zhangheihei mentioned this pull request Dec 15, 2024
Closed
24 tasks
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 12 12 100.00% []
🔵 com/starrocks/qe/DDLStmtExecutor.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

LiShuMing
LiShuMing approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@LiShuMing LiShuMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjun-git gengjun-git merged commit eefc823 into StarRocks:main Dec 16, 2024
59 of 61 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 16, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 16, 2024
@zhangheihei @mergify
[BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is …
cad861b 
…reported for dropping a materialized view. (#53951)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit eefc823)
@mergify mergify bot mentioned this pull request Dec 16, 2024
Open
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
@zhangheihei @mergify
[BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is …
22e7c99 
…reported for dropping a materialized view. (#53951)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit eefc823)
@mergify mergify bot mentioned this pull request Dec 16, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 17, 2024
@mergify @zhangheihei
[BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is …
cc88ed0 
…reported for dropping a materialized view. (backport #53951) (#53963)

Co-authored-by: zhanghe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@zhangheihei zhangheihei

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The OP_DROP_TABLE_V2 event is not triggered when an error is reported for dropping a materialized view.
3 participants
@zhangheihei @LiShuMing @gengjun-git