-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] (Part 6) Fix partition_retention_condition for iceberg with partition transforms #53869
Open
LiShuMing
wants to merge
2
commits into
StarRocks:main
Choose a base branch
from
LiShuMing:fix/main/fix_retention_condition_validation_iceberg_bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BugFix] (Part 6) Fix partition_retention_condition for iceberg with partition transforms #53869
LiShuMing
wants to merge
2
commits into
StarRocks:main
from
LiShuMing:fix/main/fix_retention_condition_validation_iceberg_bug
+1,638
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiShuMing
changed the title
[BugFix] Fix partition_retention_condition for iceberg with partition transforms
[WIP] [BugFix] Fix partition_retention_condition for iceberg with partition transforms
Dec 12, 2024
LiShuMing
force-pushed
the
fix/main/fix_retention_condition_validation_iceberg_bug
branch
2 times, most recently
from
December 13, 2024 08:46
9ac94dc
to
b496bbf
Compare
LiShuMing
changed the title
[WIP] [BugFix] Fix partition_retention_condition for iceberg with partition transforms
[BugFix] Fix partition_retention_condition for iceberg with partition transforms
Dec 13, 2024
LiShuMing
force-pushed
the
fix/main/fix_retention_condition_validation_iceberg_bug
branch
from
December 16, 2024 02:28
65c9f31
to
8b62808
Compare
LiShuMing
changed the title
[BugFix] Fix partition_retention_condition for iceberg with partition transforms
[UT] [BugFix] Fix partition_retention_condition for iceberg with partition transforms
Dec 16, 2024
LiShuMing
force-pushed
the
fix/main/fix_retention_condition_validation_iceberg_bug
branch
2 times, most recently
from
December 16, 2024 07:06
5e5ac93
to
77510dc
Compare
LiShuMing
changed the title
[UT] [BugFix] Fix partition_retention_condition for iceberg with partition transforms
[BugFix] Fix partition_retention_condition for iceberg with partition transforms
Dec 16, 2024
LiShuMing
changed the title
[BugFix] Fix partition_retention_condition for iceberg with partition transforms
[BugFix] (Part 6) Fix partition_retention_condition for iceberg with partition transforms
Dec 16, 2024
LiShuMing
force-pushed
the
fix/main/fix_retention_condition_validation_iceberg_bug
branch
from
December 17, 2024 02:48
ea1bfa1
to
2c61eaf
Compare
@mergify rebase |
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix/main/fix_retention_condition_validation_iceberg_bug
branch
from
December 17, 2024 09:40
2c61eaf
to
de93c16
Compare
✅ Branch has been successfully rebased |
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 205 / 226 (90.71%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix bugs for mv with iceberg transforms and
query_rewrite_consistency=force_mv
;What I'm doing:
query_rewrite_consistency=force_mv
:partition_retention_condition
should also take care icerberg transform in creating mv since the partition expression has been adjusted with time-zone: [Feature] (Part 2) Support create materialized view from Iceberg table with multi partition columns and partition transforms #52966query_rewrite_consistency=force_mv
;SET disable_generated_column_rewrite=TRUE;
to walk around to skip generated column rewrite and enable mv rewrite.Fixes #53117
Fixes #52576
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: