Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note on supported MongoDB versions #949

Merged
merged 4 commits into from
Apr 13, 2020
Merged

Conversation

Kami
Copy link
Member

@Kami Kami commented Dec 16, 2019

I updated a section which was out of date.

The code base has supported v3.6 and 4.0 for a while now (and 4.0 is used as a default on Ubuntu Bionic).

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BTW 3.4 is reached its EOL.

@punkrokk
Copy link
Member

punkrokk commented Feb 7, 2020

I’d like to add this the the CentOS 8 project, update this PR to include EL 8 and merge it when the EL 8 packages get released. Unless you want a new PR?

@punkrokk punkrokk added this to the 3.2.0 milestone Feb 7, 2020
@punkrokk
Copy link
Member

punkrokk commented Feb 7, 2020

Python 3 support for mongo is added in 4.2 -> Python 3.7. Boosts the Python 3.7 case.

@arm4b
Copy link
Member

arm4b commented Feb 8, 2020

@Kami From what I remember the performance issues with MongoDB 3.6 are now fixed in upstream, do you remember where is the original issue to confirm?

@arm4b
Copy link
Member

arm4b commented Feb 8, 2020

@punkrokk Not sure about py3 vs MongoDB 4.2 and what do you mean exactly. How mongodb requires python as a dependency, can you provide more info?

MongoDB 4.0 is used with StackStorm running python 3.6 under Ubuntu Bionic installation. Also pymongo (st2 pip dependency) works OK with py 3.5+: https://api.mongodb.com/python/current/python3.html

@punkrokk
Copy link
Member

punkrokk commented Feb 9, 2020

@armab i think I was confused. Python is needed when building from source, but not when using binary RPM.

@punkrokk punkrokk merged commit 02d2a09 into master Apr 13, 2020
@punkrokk punkrokk deleted the update_mongodb_docs branch April 13, 2020 18:28
@@ -1,5 +1,5 @@
.. note::

The currently supported version of MongoDB is 3.4 and 4.0. This is the version installed by
The currently supported versions of MongoDB are 3.4 and 4.0. This is the version installed by
the installer script. MongoDB 4.0 is installed by default on Ubuntu 18.04 and RHEL/CentOS8.
MongoDB 3.6 does not currently work with StackStorm. Support for MongoDB 4.0 was added in ST2 v3.1.
Copy link
Member

@arm4b arm4b Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original message with mongodb 3.6 was a bit different with this PR:

  The currently supported version of MongoDB is 3.4. This is the version installed by the installer
  script.

  MongoDB 3.6 and 4.0 are also supported by StackStorm >= 3.0.0, but we have observed some
  performance regressions with MongoDB 3.6 so the default version which is installed on Ubuntu
  Xenial (16.04) still is 3.4.

  Right now MongoDB 4.0 is only used with Ubuntu Bionic (18.04).

based on 4a65ac5

@punkrokk
Copy link
Member

punkrokk commented Apr 13, 2020 via email

@arm4b
Copy link
Member

arm4b commented Apr 13, 2020

@punkrokk Compare 4a65ac5 vs 02d2a09

I think huge part of the text/diff from this PR was lost during the git conflict resolve process.

@arm4b
Copy link
Member

arm4b commented Apr 14, 2020

#968 should fix it.

arm4b pushed a commit that referenced this pull request Apr 14, 2020
Bring back original MongoDB 3.6 message from #949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants