Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade_notes to mention fail fast on workflows #1024

Merged
merged 4 commits into from
Oct 8, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Oct 6, 2020

Included a comment on upgrade notes about fail-fast on orquesta workflows.

Designed to explain the confusion on when workflows stop, raised in StackStorm/st2#5031.

@nmaludy
Copy link
Member

nmaludy commented Oct 6, 2020

@emptywee any thoughts here?

@emptywee
Copy link

emptywee commented Oct 6, 2020

Yes, sounds good. Would be better if we had a choice in how we want the engine to behave (like I proposed to have fail and terminate and one would keep other branches running, while the other would terminate the workflow for good), but for now it is more clear to understand why your ex-mistral workflows converted to orquesta don't work the same way.

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this specific feature deserves a mention in the upgrade notes. There are other Mistral -> Orquesta nuance that users should be aware as well. Why not just ask users to review the orquesta documentation in general?

@amanda11 amanda11 merged commit 8ce5cdb into master Oct 8, 2020
@amanda11 amanda11 deleted the orquesta_workflow_fail branch October 8, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants