Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of RHEL 6 / CentOS 6 #188

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Deprecation of RHEL 6 / CentOS 6 #188

merged 1 commit into from
Jul 30, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jul 10, 2020 •
edited
Loading

Remove running of CI jobs for EL6.

addressing st2ci - remove EL6 from StackStorm/community#39

@amanda11
Copy link
Contributor Author

There were a few points in these files I didn't quite understand. EL8 didn't seem to be in, so I put in EL8. But if there's some reason for EL8 not being in then good to understand why:

  • actions/workflows/promote_package.yaml
  • actions/promote_package.yaml
  • aliases/promote_package.yaml

@amanda11 amanda11 marked this pull request as draft July 10, 2020 14:33
@amanda11 amanda11 changed the title Deprecation of RHEL 6 / CentOS 6 [WIP] Deprecation of RHEL 6 / CentOS 6 Jul 10, 2020
@amanda11 amanda11 marked this pull request as ready for review July 10, 2020 22:49
blag
blag approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should also add bionic to the promote packages alias, although I haven't seen anybody use that alias. So maybe we should start using that alias too. 😆

@arm4b arm4b mentioned this pull request Jul 16, 2020
Closed
24 tasks
@amanda11
Copy link
Contributor Author

@blag is there any follow-up required for the EL6 removal? Or can this be merged?

punkrokk
punkrokk approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amanda11

@blag
Copy link
Contributor

blag commented Jul 30, 2020

No follow up required. Thanks for your contribution!

@blag blag merged commit adb4ec2 into StackStorm:master Jul 30, 2020
@arm4b
Copy link
Member

arm4b commented Jul 31, 2020

@blag @punkrokk Can someone please ensure that updated version of st2ci is deployed on a live server?

@punkrokk
Copy link
Member

@armab Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punkrokk punkrokk punkrokk approved these changes

@blag blag blag approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amanda11 @blag @arm4b @punkrokk