[WIP] Automatically cancel old PR end to end builds when a new one is triggered #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds for a particular PR before starting a new build. This way we speed things up and save some resources when multiple commits are pushed to a branch in a short time frame which results in multiple e2e builds.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
st2_pkg_e2e_test.metaaction / workflow to cancel any existing old builds for a particular PR before starting a new one.This is similar to Travis and Circle CI behavior of auto canceling of old builds when a new build is triggered by pushing changes to a branch. This allows us to speed things up and save resources and utilization on CICD.
To logic to determine old builds is simple - we check Circle CI build number and if that one is < current build number, then we mark that build as old and cancel it.
TODO
st2ci.st2_pkg_e2e_test_cleanup) for a particular build. That action is idempotent so if it fails we can simply ignore it.