Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HipChat adapter #154

Merged
merged 8 commits into from
Jul 9, 2020
Merged

Remove HipChat adapter #154

merged 8 commits into from
Jul 9, 2020

Conversation

blag
Copy link
Contributor

@blag blag commented Jul 8, 2020

This PR removes the HipChat hubot adapter from NPM dependencies, removes the configuration section from st2chatops.env, and removes HipChat from the list of supported providers.

TODO:

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 considering the builds pass

@blag blag merged commit 9420a48 into master Jul 9, 2020
@blag blag deleted the remove-hipchat branch July 9, 2020 19:31
@@ -10,13 +10,13 @@ RUN curl --silent --location https://rpm.nodesource.com/setup_10.x | bash -
{%- if version in ('centos8') %}

# Install development tools
yum -y module install nodejs:10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Good find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants