Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update st2chatops to use fixed Microsoft Teams and Cisco Spark adapters #148

Merged
merged 6 commits into from
Apr 15, 2020

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Apr 15, 2020

Closes #147
Fixes #141

This updates Microsoft Teams (#141) and Cisco Spark (StackStorm/hubot-stackstorm#200) hubot adapters that include latest bugfixes, as well as hubot-stackstorm.

This is the last fix needed for upcoming v3.2 release.

@arm4b arm4b added the feature label Apr 15, 2020
@arm4b arm4b added this to the 3.2.0 milestone Apr 15, 2020
@arm4b arm4b requested a review from blag April 15, 2020 15:41
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start a CHANGELOG for this repo?

@arm4b
Copy link
Member Author

arm4b commented Apr 15, 2020

@nmaludy Sure, we can. I think it's however out of scope of this PR as having only 1 record associated with v3.2 would look misleading.

If someone is motivated to put a few lines of history together (including hubot-stackstorm sub-tree), - that would be a great addition to do in a new PR 👍 Not to forget the release Automation changes as it's usually cuts the changelog for the new release.

@arm4b
Copy link
Member Author

arm4b commented Apr 15, 2020

Thanks, documented #149 as Issue so we don't forget about CHANGELOG as an enhancement for this repository.

@arm4b arm4b merged commit ee2f547 into master Apr 15, 2020
@blag blag deleted the update/hubot-stackstorm branch June 5, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants