Skip to content

Commit

Permalink
Fix installing node-gyp on centos8 and regenerate centos8 Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
blag committed Jul 9, 2020
1 parent ca29c05 commit 9afce7f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packagingenv/Dockerfile.template
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ RUN yum -y module install nodejs:10
RUN yum -y install python3

# Upgrade gyp to a python3 compatible version
RUN npm explore npm -g -- npm install node-gyp@latest
RUN npm install -g node-gyp@latest

{%- endif %}

Expand Down
6 changes: 5 additions & 1 deletion packagingenv/centos8/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ RUN yum -y module install nodejs:10
RUN yum -y install python3

# Upgrade gyp to a python3 compatible version
RUN npm explore npm -g -- npm install node-gyp@latest
RUN npm install -g node-gyp@latest

# Install development tools
RUN yum -y install nodejs

COPY docker-entrypoint.sh /entrypoint.sh
ENTRYPOINT [ "/entrypoint.sh" ]

0 comments on commit 9afce7f

Please sign in to comment.