Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced error message when st2_prep_release is run twice #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# Changelog

## 0.1.3

Added descriptive error message to `st2cd.st2_prep_release_for_st2` in case that workflow
is run twice. This is in hope that it helps the next person who tries to run this workflow
and is confused about it erroring and not being idempotent.

Contributed by Nick Maludy (@nmaludy)

## 0.1.2

Removed EL6 and added EL8
Expand Down
2 changes: 1 addition & 1 deletion actions/st2_prep_release_for_st2.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ PUSH=0
BRANCH_EXISTS=`git ls-remote --heads ${GIT_REPO} | grep refs/heads/${BRANCH} || true`

if [[ ! -z "${BRANCH_EXISTS}" ]]; then
>&2 echo "ERROR: Branch ${BRANCH} already exist in ${GIT_REPO}."
>&2 echo "ERROR: Branch ${BRANCH} already exist in ${GIT_REPO}. If you are trying to include changes made after running the 'prep release' step, then simply merge your changes into the existing release branch ${BRANCH}. This step creates release branches (vX.Y) and changelogs across the various repos, and during the release you can incorporate changes/fixes into those release branches. Changes must be merged into these release branches in order to be included in the final release."
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletion pack.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name : st2cd
description : Continuous delivery pipeline at StackStorm
version : 0.1.3
version : 0.1.4
author : st2-dev
email : [email protected]