Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mistral from st2cd #440

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Aug 3, 2020

Remove mistral from st2cd

Addresses st2cd entry in StackStorm/st2#4762

@amanda11
Copy link
Contributor Author

amanda11 commented Aug 3, 2020

I couldn't test installation of this pack as couldn't find the pack githubwebhook which was referenced.

Also there is an UPDATE_MISTRAL parameter passed to st2_chg_ver_for_st2.sh. I've left the parameter in, but it has no affect.
I can remove this and change the order of parameters, but I wasn't sure where this workflow was called from to know if that was safe to do.

@amanda11 amanda11 changed the title Remove mistral from st2cd [WIP] Remove mistral from st2cd Aug 3, 2020
@arm4b arm4b requested review from blag and m4dcoder August 3, 2020 20:32
Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants