Deprecate RHEL 6 / CentOS 6 #439
Conversation
|
A few files where I added EL8 references, as weren't sure why they were missing - but need careful review:
In addition, there is still a file: ./rules/st2cd_slack_pkg_rhel6.yaml - I wasn't quite sure where this rule fit in, as we didn't have one for el7 or el8 - just seem to have one slack rule. So wasn't sure if this needed amending. |
amanda11
changed the title
…t need the check on bats-core directory
|
@blag Is there any follow-up required on this, I think I've addressed your review comment. |
|
Checking on one last thing before merging. |
actions/setup_e2e_tests.sh
Outdated
| rm -rf bats-core | ||
| git clone --branch add_per_test_timing_information --depth 1 https://github |
actions/setup_e2e_tests.sh
Outdated
| # Remove bats-core if it already exists (this happens when test workflows | ||
| # are re-run on a server when tests are debugged) | ||
| if [[ -d bats-core ]]; then | ||
| # bats not available in epel for EL 8, Install from GitHub |
There was a problem hiding this comment.
This is going to sound weird. You're right that bats is not available in EPEL for RHEL 8. But it is available, for some reason, via npm. So instead of installing from GitHub, let's install with npm:
npm install --global bats
|
@blag Should have addressed your review comments, thanks for spotting. |
|
Thanks! |
Remove EL6 builds
addressing st2cd - remove EL6 from StackStorm/community#39