isotime formatter: assume incoming epoch timestamp being in UTC #4668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the platform where st2 is running is configured with non UTC timezone executions retrieved from st2api have
log
entries with incorrectly formatted timestamp as shown on this screenshot:After debugging it, turns out that api model is receiving them as unix timestamps, parsing them as local time producing naive datetime object and further assuming it's in UTC timezone, resulting in wrong timestamps provided via API calls.
This PR fixes that, but I am not sure if anything else may get affected. Maybe a proper way would be giving non-formatted timestamp and let API consumers deal with time zones?
@Kami please, take a look and chime in. Others welcome too.