Add some metric instrumentation to the notifer service code #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have useless / confusing data (aka those functions will complete immediately).
|
Docs at StackStorm/st2docs#846. |
arm4b
approved these changes
Feb 11, 2019
|
@armab Yeah that one is a bit of an exception, we usually don't need such granular metrics, but this one is a bit special. I hope we can remove it once we get a better picture (it shouldn't cause any overhead and it's not documented as a public exposed metric either). |
Kami
added a commit
that referenced
this pull request
Mar 13, 2019
to only be dispatched on completed states, but not on custom states if action_sensor.emit_when config option was configured. Issue was inadverently introduced in #4536, Issue reported by Hiroyasu OHYAMA (@userlocalhost).
Kami
added a commit
that referenced
this pull request
Mar 13, 2019
to only be dispatched on completed states, but not on custom states if action_sensor.emit_when config option was configured. Issue was inadverently introduced in #4536, Issue reported by Hiroyasu OHYAMA (@userlocalhost).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some metrics instrumentation to the
st2notifierservice code.We don't have any now so it would be good to have some. Especially because we noticed some "interesting" CPU spikes in the notifier service on our CICD server (could be related to blocking Jinja template rendering which maybe we can offload to a thread pool to avoid blocking main thread and reduce the main process CPU usage).
TODO