Encode plaintext before padding it #4527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: I'm no crypto expert, so please review with care. I ran into this same issue when trying to encrypt utf-8 text: StackStorm#4513 I believe the problem is that the plaintext is padded before it's encoded, and the encoding changes the length of the data. Moving the encoding before the padding seems to resolve the issue.
|
Hmm, nevermind. I believe this fails pull request works on Python 2 but not on Python 3, because pkcs5_pad can't concatenate str and bytes on Python 3: st2/st2common/st2common/util/crypto.py Line 370 in b100848 Any thoughts on how to address this? |
|
Thanks again for reporting this issue and working on it. You were indeed on a right track. We need to convert data to bytes before we pad it - #4528 (and also update pad function so it handles bytes correctly). Fix will be included in a future v2.10.2 release. |
|
🙌🏻Thanks for the quick follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: I'm no crypto expert, so please review with care.
I ran into this same issue when trying to encrypt utf-8 text:
#4513
I believe the problem is that the plaintext is padded before it's encoded, and the encoding changes the length of the data.
Moving the encoding before the padding seems to resolve the issue.