NGINX: Use 308 redirect rather than 301 #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our default NGINX configuration redirects `http://` requests to `https://`. This uses a 301 redirect. When clients see this, they will either switch PUT/POST requests to GET, or they may continue with PUT/POST, but with no payload. This change uses [HTTP 308](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/308) instead. The request method and body will be unchanged. This will reduce confusion for people using custom code that targets `http://<ST2>/`, rather than `https://<ST2>`
|
@armab would appreciate your input on this. No rush, does not need to be 2.9, could be 3.0. |
|
According to https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.2 the issue with
But still, good to have this improvement to be on the safe side 👍 |
arm4b
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default NGINX configuration redirects
http://requests tohttps://. This uses a 301 redirect. When clients see this, they will either switch PUT/POST requests to GET, or they may continue with PUT/POST, but with no payload.This change uses HTTP 308 instead. The request method and body will be unchanged.
This will reduce confusion for people using custom code that targets
http://<ST2>/, rather thanhttps://<ST2>