Update action entry point API controller to return correct Content-Type response header #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
commented
Sep 3, 2018
| # Special case if /etc/mime.types doesn't contain entry for yaml, py | ||
| if not content_type: | ||
| _, extension = os.path.splitext(abs_path) | ||
| if extension in ['.yaml', '.yml']: |
There was a problem hiding this comment.
I added entries for "common cases" such as YAML and Python files.
Usually default /etc/mime.types file doesn't contain entry for YAML files so the endpoint would always just return text/plain which is not desired.
Kami
commented
Sep 3, 2018
| @@ -531,7 +531,12 @@ def __init__(self, **entries): | |||
|
|
|||
| try: | |||
| validator = CustomValidator(response_spec['schema'], resolver=self.spec_resolver) | |||
| validator.validate(resp.json) | |||
|
|
|||
| response_type = response_spec['schema'].get('type', 'json') | |||
There was a problem hiding this comment.
@enykeev I needed to make change since our router code didn't really correctly support non JSON responses.
It always called resp.json which would fail on non-json responses.
bigmstone
approved these changes
Sep 10, 2018
| @@ -186,10 +191,32 @@ def get_one(self, ref_or_id, requester_user): | |||
| raise StackStormDBObjectNotFoundError('Action ref_or_id=%s has no entry_point to output' | |||
| % ref_or_id) | |||
|
|
|||
| with open(abs_path) as file: | |||
| content = file.read() | |||
| with codecs.open(abs_path, 'r') as fp: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
GET /v1/actions/views/entry_point/<action ref>API endpoint to return correct header based on the entry point content type (yaml, python script, bash script, etc.).Previously it would always incorrectly return
application/json.Resolves #4269.