Fix bug where objects and arrays marked as secret weren't being masked

[nmaludy]

Most likely due to the re-work of secret masking here #4140 objects and arrays that were marked with secret: true were not being masked. See #4235 for details on the symptoms.

This PR addresses this by looking for the secret property on object and array types. It then treats all data within the object or array as secret, returning a single masked value.

Example of the fixed version:

$ st2 run default.secret_objects secret_object='{"abc": "123"}' secret_array='[1, 2, 3]'
.
id: 5b44de76a814c004961c020e
status: succeeded
parameters: 
  secret_object: '********'
  secret_array: '********'
result: 
  failed: false
  return_code: 0
  stderr: ''
  stdout: ''
  succeeded: true

FYI, i create a unit test for this edge case so we can verify that it is not exposed in the future.

[nmaludy]

Closes #4235

[nmaludy]

@Kami i was able to find and fix the issue, please let me know if you have any comments

[Kami]

@nmaludy Thanks, will have a look.

[Kami]

It also wouldn't hurt to add a test case for scenarios where we have an object which is marked "secret: true" at top level, but it also has a sub-schema with different items of which some have "secret: true" attribute. Same goes for array.

I assume in such scenarios, if top level "secret: true" attribute is present, this top level attribute should have a precedence (and we could even ignore / skip iterating over child object / array attributes).

[Kami]

Great 👍

That's also a more common scenario and it's much more performant :)

[Kami]

Thanks for good work on the tests 👍