-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make st2client setup.py requirements consistent #4209
Conversation
FWIW, I would be much happier about having this auto-synced. I'm just trying to deal with some immediate pain, but a 'proper' fix would be welcome. |
We fixed Still need to verify it works with various versions of pip (pre 9, 9, and 10). I believe in the past there were issues with older versions of pip. |
I did some digging in and testing - we now install pip 9.0.1 inside st2 and pack virtual environments so I believe we should be fine. It doesn't work with very ancient versions of pip, but I just checked and most other software also doesn't support pip < 9.0 so we should be fine. I will push a change which updates it to use @LindsayHill thanks for opening this PR and having us reevaluate this decision again. I also tagged this issue with 2.9.0 and will wait with merging this we have a branch for v2.8. |
requirements.txt file. This is now possible since we install pip 9.0.0 in pack and st2 virtual environments. Keep in mind that this won't work with very old versions of pip (< 9.0).
of pip where the attribute was called req.url (in newer versions it's called req.link).
Thanks for that @Kami. Totally fine for this to be 2.9.0. It's not a 2.8.0 blocker. |
I pushed some more changes / fixes to this branch and confirmed it indeed fixes issue reported in #3367 - #3367 (comment). |
Installing st2client using
pip install st2client
has missing dependencies. It is unusable until you runpip install argcomplete pytz jsonschema prompt_toolkit python-editor
.This PR makes the setup.py requirements consistent with those in requirements.txt.
Fixes #3367