Include git revision of StackStorm release in the st2 --version output when running a dev release #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"st2 --version" CLI command and when running a dev release.
arm4b
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
st2 --versionCLI command to also include git revision of the release when running a dev release and when file with package metadata is available.Before:
After:
This saves some typing since you don't need to manually check the package metadata file (
/opt/stackstorm/st2/package.meta).If others think it makes sense, we could also include git revision when running a stable (non dev) release, but I personally think that's not needed and it would just make it confusing (we have a corresponding git tag for each final release which is not the case for dev releases).
TODO