Fix mistral callback failure when result contains unicode #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4dcoder
force-pushed
the
mistral-callback-unicode
branch
from
bbbaeb7 to
946c68a
Compare
Kami
reviewed
Sep 7, 2017
| action_executions.ActionExecutionManager, 'update', | ||
| mock.MagicMock(return_value=None)) | ||
| def test_callback_handler_with_result_as_dict_with_unicode_type(self): | ||
| self.callback_class.callback('http://127.0.0.1:8989/v2/action_executions/12345', {}, |
There was a problem hiding this comment.
It would be good to test unicode for all the various type (string, list, dict) and also add a test case with actual unicode string (💩) in addition to existing tests with the unicode escape sequences.
There was a problem hiding this comment.
@Kami added more unit tests as requested
|
Added v2.4.1 milestone since I assume this will / should go into v2.4.1. |
|
👍 There are also some Unit tests failing in Travis. |
When result of action execution contains unicode, Mistral callback fails and leads to orphaned workflow execution.
m4dcoder
force-pushed
the
mistral-callback-unicode
branch
from
757f53f to
eb3c5c1
Compare
arm4b
approved these changes
Sep 8, 2017
Kami
approved these changes
Sep 8, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When result of action execution contains unicode, Mistral callback fails and leads to orphaned workflow execution.