CI check which verifies that all the automatically generated files are up to date #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have been re-generated, committed and included in the changeset.
values change based on the environment where this script run. This way we ensure consistent and stable output of this script, regardgless of where it runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new CI check which verifies that all the automatically generated files are up to date (this means that if the file source file has been changed, automatically generated file has been re-generated and included in the changeset).
This way we can be sure we won't forget to run the auto generation script (they are part of all the Make targets, but it still happens people forget to include and commit it as part of their changes).
Thanks to @enykeev for the suggestion.