Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL7 to use python3 #671

Merged
merged 2 commits into from
Nov 17, 2020
Merged

EL7 to use python3 #671

merged 2 commits into from
Nov 17, 2020

Conversation

amanda11
Copy link
Contributor

Update the EL7 packages so that they use python3 not python2.

Part of StackStorm/community#54

@amanda11
Copy link
Contributor Author

amanda11 commented Nov 10, 2020

Comments:

  • Tested with docker images built by Update to use PY3 on EL7 st2packaging-dockerfiles#92, and then manual install on EL7.
  • In EL8 we build cryptography. I haven't built cryptography for EL7, and it appears to use the same version of cryptography. Tested on a deployed EL7 with new packages that st2 key set/get with encrypted secrets worked.
  • Also for EL8 in the st2.spec there are mention of need to get access to python packages available within BUILDROOT when outside venv, and it especially has BuildRequires in. I didn't need these steps to build the python3 EL7 ST2 package, but wanted to verify if those directives were used for anything other than building the packge.

@amanda11
Copy link
Contributor Author

amanda11 commented Nov 12, 2020

Tested 3.3 EL7 -> 3.4dev EL7 upgrade using new package. Manuallly install of libselinux-python3 before upgrade. Upgrade successful and self-check passed.

$ st2 --version
st2 3.4dev (632a07e), on Python 3.6.8

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked flawlessly for me when trying the el7 packages manually.

Great work 👍

@arm4b arm4b added this to the 3.4.0 milestone Nov 17, 2020
@amanda11 amanda11 merged commit 625ce12 into master Nov 17, 2020
@amanda11 amanda11 deleted the el7_py3 branch November 17, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants