Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EL6 and st2python #658

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Remove EL6 and st2python #658

merged 4 commits into from
Aug 4, 2020

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Aug 3, 2020

Finishing the work related to EL6 deprecation in st2 packages: StackStorm/community#39

@arm4b arm4b marked this pull request as ready for review August 3, 2020 14:40
@arm4b arm4b requested review from a team and removed request for a team August 3, 2020 14:41
@punkrokk
Copy link
Member

punkrokk commented Aug 4, 2020

Phew, that was a lot of code removed.

Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that it's not that hard to package a version of python is absolutely necessary.

@arm4b
Copy link
Member Author

arm4b commented Aug 4, 2020

It may be hard to do a proper background work and package it properly with all the corner cases researched (EL6 st2python code might be very different for EL7).

However the hardest thing is really maintain and update the python package properly.
EL6 st2python package wasn't updated for 4 years I guess? I'm sure it's a can of worms now in terms of security. I'm happy to finally get rid of it.

@punkrokk
Copy link
Member

punkrokk commented Aug 4, 2020 via email

@arm4b arm4b merged commit b3c6340 into master Aug 4, 2020
@arm4b arm4b deleted the remove/el6 branch August 4, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants