-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EL6 and st2python #658
Conversation
Phew, that was a lot of code removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that it's not that
hard to package a version of python is absolutely necessary.
It may be hard to do a proper background work and package it properly with all the corner cases researched (EL6 st2python code might be very different for EL7). However the hardest thing is really maintain and update the python package properly. |
Not suggesting we do it, just pointing out that it’s not impossible :P
… On Aug 4, 2020, at 2:53 PM, Eugen C. ***@***.***> wrote:
It may be hard to do a research and package it properly with all the corner cases researched (EL6 st2python code might be very different for EL7).
However the hardest thing is really maintain and update the python package properly.
EL6 st2python package wasn't updated for 4 years I guess? I'm sure it's a can of worms now in terms of security. I'm happy to finally get rid of it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#658 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIMM6RSM26YCKHORZ4KYX3R7BKKJANCNFSM4PTI3JTA>.
|
Finishing the work related to
EL6
deprecation in st2 packages: StackStorm/community#39