-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inspect context and detect undefined task logic. #254
Improve inspect context and detect undefined task logic. #254
Conversation
Yogesh Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me. This is a great find. n^2 complexity fix.
@yogeshgoyal26 Looks like we have a Changelog for Orquestra: https://github.com/StackStorm/orquesta/blob/master/CHANGELOG.rst |
Improvement in inspect context and detect undefined task logic to improve overall execution performance of inspect. Specifically scenarios where the tasks success and failure are moved to same task in the workflow, then in that case the tasks are added to the queue in multiple of 2, which increase the overall time take by inspect method.
Below is an example workflow:
Task1 - Added 1 time
Task2 - Added 2 times
Task3 - Added 4 times
Task4 - Added 8 times
..