Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value in quotes in shorthand publish should be evaluated as string type #130

Closed
m4dcoder opened this issue Feb 12, 2019 · 0 comments
Closed

Value in quotes in shorthand publish should be evaluated as string type #130

m4dcoder opened this issue Feb 12, 2019 · 0 comments
Assignees
@jinpingh

Comments

@m4dcoder
Copy link
Collaborator

For shorthand publish such as x="false" and y="1234" where the value is in quotes (single or double), the value should be kept as string type and not be auto-converted to bool, integer, or other types.
@m4dcoder m4dcoder mentioned this issue Feb 12, 2019
Merged
jinpingh added a commit that referenced this issue Feb 13, 2019
@jinpingh
Value in quotes in shorthand publish should be evaluated as string type
f533d88 
Fixes issue #130

During `parse_inline_params` is called to parse parameters input, the leading and trailing single/double quotes is removed. Digit and True/False in quotes will be parsed as number and boolean type instead of String after `json.loads()`.

Solution:
For string in quotes (not includes dictionary  `'x=\'{\"a\": 1}\''`), 'json.loads' is not called.
@jinpingh jinpingh mentioned this issue Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinpingh jinpingh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m4dcoder @jinpingh