Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#246] Drop Ubuntu Trusty support #265

Merged
merged 2 commits into from
Jun 26, 2020
Merged

[#246] Drop Ubuntu Trusty support #265

merged 2 commits into from
Jun 26, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jun 26, 2020 •
edited by arm4b
Loading

Closes #246

Remove ubuntu trusty which was dropped since st2 v3.2.1

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jun 26, 2020
@amanda11 amanda11 marked this pull request as draft June 26, 2020 09:36
@amanda11 amanda11 changed the title [#246] WIP Drop Ubuntu Trusty support [#246] Drop Ubuntu Trusty support Jun 26, 2020
@amanda11 amanda11 marked this pull request as ready for review June 26, 2020 10:22
This was referenced Jun 26, 2020
Merged
Merged
LindsayHill
LindsayHill approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@LindsayHill LindsayHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something very pleasing to me about removing things

@arm4b
Copy link
Member

arm4b commented Jun 26, 2020

I just updated PR description to close the #246 once we merge this.
@amanda11 this might be useful: https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

arm4b
arm4b approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that!
Can't wait when we'll remove EL6 with all its workarounds and hacks.

Thanks a lot @amanda11 for the contribution!

@arm4b arm4b merged commit cf00d9f into StackStorm:master Jun 26, 2020
@amanda11
Copy link
Contributor Author

I just updated PR description to close the #246 once we merge this.
@amanda11 this might be useful: https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Didn't know that - brilliant - will use that from now on. Thanks for pointer.

@amanda11
Copy link
Contributor Author

Any changes requested? Approved but awaiting merging by someone with write access.

@arm4b
Copy link
Member

arm4b commented Jun 29, 2020

I think this PR was merged. Good work here!

@arm4b arm4b mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindsayHill LindsayHill LindsayHill approved these changes

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
enhancement size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Ubuntu 14 support since st2 v3.1
3 participants
@amanda11 @arm4b @LindsayHill