Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange-wide updates incl. drop py2.7 tests #18

Closed
wants to merge 4 commits into from
Closed

Exchange-wide updates incl. drop py2.7 tests #18

wants to merge 4 commits into from

Conversation

cognifloyd
Copy link
Member

  • Test infra for py2.7 is broken. Drop it.
  • bootstrap tests/setup_testing_env.sh
  • drop unnecessary execute permissions

@cognifloyd
Test infra for py2.7 is broken. Drop it.
f3777b2 
We will no longer test packs with python2.7, as it is broken and the fix
(re-adding 2.7) is too invasive across all of our infrastructure.

We continue supporting 2.7 but only on an as-reported basis.
If someone submits a PR for 2.7 and it does not break with python 3, great.
If a pack is upgraded so that it can only be used with python 3,
then people can downgrade to an earlier version that supported python 2.

StackStorm/community#40 (comment)
@cognifloyd
bootstrap tests/setup_testing_env.sh
48a6a95 
see: StackStorm-Exchange/ci#101
@cognifloyd
drop unnecessary execute permissions
a58fce8
@cognifloyd cognifloyd mentioned this pull request Jan 30, 2021
Merged
@cognifloyd cognifloyd mentioned this pull request Jan 30, 2021
Closed
arm4b
arm4b suggested changes Jan 30, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good draft 👍

As noted before in the Discussion StackStorm/community#40 (comment) dropping the Python2 Tests in StackStorm Exchange de-facto means deprecation of the Python 2 with the respective pack metadata consequences, eg. python_versions.

Besides of that, let's do it nicely this time. Can you work with @blag or @nmaludy so they push your changes directly to master to avoid new portion of unnecessary notifications?

@cognifloyd
Copy link
Member Author

@armab are you saying you'd like us to remove python_versions from pack metadata when we drop the python 2.7 exchange tests? Or put a message somewhere saying it's deprecated?

@blag
Copy link
Contributor

blag commented Jan 30, 2021

We should not (yet) change python_version. We could add a warning in the READMEs, but honestly, and this point I don't think that will be too helpful. Anybody who is still running Python 2 already knows the risks they are taking. Whatever warning we would add would just be a drop in the ocean.

It would be ideal to test both versions of Python while we support both, there is no rule that that has to be the case. And we are already being nice by not ripping out Python 2 code and Python 2 from python_versions already.

@arm4b
Copy link
Member

arm4b commented Jan 30, 2021

Replied in StackStorm/community#40 (comment)

@cognifloyd cognifloyd closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cognifloyd @blag @arm4b