Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Risk calculation button has wrong colour on page reload #51

Closed
kenmeacham opened this issue Jun 30, 2023 · 1 comment
Closed

Risk calculation button has wrong colour on page reload #51

kenmeacham opened this issue Jun 30, 2023 · 1 comment
Assignees
@kenmeacham
Labels
bug Something isn't working
Milestone
Release version 3...

Comments

@kenmeacham
Copy link
Contributor

If an unsaved risk calculation has been done then the risk button is coloured orange. If the page is then reloaded the button appears green but there is no risk data in the page. The button should be red.

Migrated from https://iglab.it-innovation.soton.ac.uk/Security/system-modeller/-/issues/1256

CC @scp93ch
@kenmeacham kenmeacham added the bug Something isn't working label Jun 30, 2023
@kenmeacham kenmeacham self-assigned this Jun 30, 2023
kenmeacham added a commit that referenced this issue Jun 30, 2023
@kenmeacham
#51, #3: Ensure that risksValid and riskCalculationMode updates are n…
65eb637 
…ot persisted when user selects to NOT save risk calc results. Validation now clears these flags. Fix corresponding unit test code.
@kenmeacham
Copy link
Contributor Author

This is now fixed, via a direct commit on the #3 branch. See above.

@kenmeacham kenmeacham added this to the Release version 3.5.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenmeacham kenmeacham

Labels
bug Something isn't working
Projects
None yet
Milestone
Release version 3.5.0
Development

No branches or pull requests
1 participant
@kenmeacham