Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] Youtube api shutdown | YouTube API Compliance Review #738

Closed
Splamy opened this issue Feb 29, 2020 · 4 comments
Closed

[Announcement] Youtube api shutdown | YouTube API Compliance Review #738

Splamy opened this issue Feb 29, 2020 · 4 comments
Milestone

Comments

@Splamy
Copy link
Owner

Splamy commented Feb 29, 2020

What happened

As some of you may know the TS3AudioBot uses the youtube api to fetch some data fast and efficiently like playing by search term or loading playlists.
To make operations smoother we shipped our own youtube api key with the bot and this worked very well until we now got an email for the 'YouTube API Compliance Review'.
This means that the api has probably reached a certain usage threshold (currently 50k-80k requests per day) where youtube wants to verify the correct use of their services.
While we are happy about these usage numbers this means we will have to remove the key since as you may imagine the TS3AB's usage of the youtube api is not quite so compilant with the youtube terms of service.

What now

I will shutdown our youtube-api key this evening.
This means loading youtube playllists, searching for youtube songs, and youtube thumbnail loading will not work anymore.

What will happen

I have found another project with the same problem: natumbri/mopidy-youtube#92
The solution will be to simply rewrite our loader to use youtube-dl for everything where we used the api before.
This will maybe make a few calls marginally slower (probably <1sec) but we shouldn't need any youtube api keys anymore.

Notes

  • You can compile the project and use your own api key until we get everything back to work
  • I am considereing whether to keep the youtube-api functions as a second alternative in the code so users can still just use their own youtube-api key, however this means more maintaining work for the youtube loader when something changes.

Update

Alright, the new dev build (starting with 0.11.0-alpha.47) can now search and import playlists again.
You will need youtube-dl for those features to work now.
I've left the old api functions in for now, but without any guarantees that it might break. The bot will use the youtube api if you have set a API key in the config. Otherwise it will use the new youtube-dl based loader.

@Splamy Splamy pinned this issue Feb 29, 2020
@Splamy Splamy added this to the 0.11.0 milestone Feb 29, 2020
@zmechu
Copy link

zmechu commented Mar 1, 2020

80k requests per day - it seems TS3AudioBot is a great project :-)

Where is in bot source code (file and line) API key to exchange for own one?

Or, maybe kind of "yt-api-key=[...]" as new option in config file will be easiest way?

@Splamy
Copy link
Owner Author

Splamy commented Mar 2, 2020

Yeah, as requested in #741 I will add a config value, so people can still use the old functions until everthing is switched to youtube-dl

@zmechu
Copy link

zmechu commented Mar 3, 2020

Dev dotnet version works fine with API key in config file. Thanks!

@Splamy
Copy link
Owner Author

Splamy commented Mar 12, 2020

Alright, the new dev build can now search and import playlists again.
You will need youtube-dl for those features to work now.
I've left the old api functions in for now, but without any guarantees that it might break. The bot will use the youtube api if you have set a API key in the config. Otherwise it will use the new youtube-dl based loader.

@Splamy Splamy closed this as completed Mar 16, 2020
@Splamy Splamy unpinned this issue Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants