Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelData: add "channel_description" field #629

Closed
SomeSpy opened this issue Sep 6, 2019 · 2 comments
Closed

ChannelData: add "channel_description" field #629

SomeSpy opened this issue Sep 6, 2019 · 2 comments

Comments

@SomeSpy
Copy link

SomeSpy commented Sep 6, 2019

Hi @Splamy

In Developer branch:

  1. Can you add "channel_description" field to ChannelData class? (via Messages.toml)
  2. Can you add "channelinfo" command (by ChannelInfoRequest parameter) to Ts3BaseFunctions class?
  3. Can you add "channeledit" command to Ts3BaseFunctions class?

Thanks!

Splamy added a commit that referenced this issue Nov 3, 2019
- Fixes from typesafe ids
- More cleanup
- Closes #629
@Splamy
Copy link
Owner

Splamy commented Nov 3, 2019

The ChannelData you are referring to belongs to channellist and has no channel_description.
To prevent confusion i renamed the serialization objects to ChannelInfoResponse and ChannelListResponse to prevent confusion. ChannelInfoResponse has the channel_description field.

I've also added both requested commands and various other channel commands.

By the way, when you are using the full client you can get a better channel view by accessing the Ts3FullClient.Book.Channels dictionary. This makes channellist and channelinfo superfluous. (You have to request the channel_description manually still tho, some convenience commands are still in work)

@SomeSpy
Copy link
Author

SomeSpy commented Nov 3, 2019

@Splamy many thanks!

@Splamy Splamy closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants