Allow custom riscv toolchain paths #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preston-evans98
approved these changes
Apr 23, 2024
preston-evans98
approved these changes
Apr 23, 2024
|
Confirmed that this build still works as expected on macOS. Thanks for the PR @zvolin! |
preston-evans98
merged commit c921ac6
into
Sovereign-Labs:risc0-compatible-0-28-2
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up flags a bit.
Both -O3 and -Os were set, I left the -Os but if you want I can switch to O3.
The other thing is that previously the paths were hardcoded I think for apple devices, could you check if this still builds properly on your Macs?