Fix FP S3878: #6893 and #6894 #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/fix-S3878-array-paramas
branch
from
53c8632 to
6a3858a
Compare
|
@antonioaversa or @Tim-Pohlmann (whoever reviews) - all ITs are killed FPs. |
antonioaversa
requested changes
Jun 5, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/ArrayPassedAsParams.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ArrayPassedAsParamsBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ArrayPassedAsParamsBase.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/ArrayPassedAsParams.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/fix-S3878-array-paramas
branch
2 times, most recently
from
2583d09 to
089156d
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fix-S3878-array-paramas
branch
2 times, most recently
from
402882e to
7361e8c
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fix-S3878-array-paramas
branch
2 times, most recently
from
f696d63 to
7614e1b
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fix-S3878-array-paramas
branch
from
e7eda3d to
80d2ec3
Compare
antonioaversa
requested changes
Jun 14, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/ArrayPassedAsParams.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ArrayPassedAsParams.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ArrayPassedAsParamsBase.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/ArrayPassedAsParams.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/ArrayPassedAsParams.vb
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ArrayPassedAsParamsBase.cs
Outdated
Show resolved
Hide resolved
antonioaversa
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
LGTM!
The new flow is easier to understand!
I left a minor comment here.
| ArrayElementType(lastArgument, model) is { IsReferenceType: true } elementType | ||
| && !elementType.Is(KnownType.System_Object) | ||
| && parameterLookup.TryGetSyntax(param, out var arguments) | ||
| && arguments.Count() is 1; |
There was a problem hiding this comment.
arguments should be an ImmutableArray, which has the Length property, which is definitely O(1).
Count, however, is from LINQ and is in general O(n). While Count should have optimized code for IList implementers (several LINQ methods do), for arrays I would directly use Length.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6893
Fixes #6894