Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0 #38

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

0.2.0 #38

wants to merge 18 commits into from

Conversation

MrSerge01
Copy link
Member

@MrSerge01 MrSerge01 commented Nov 27, 2024

Added

  • Moderation notes
  • pluralOrNot

Types for settings

  • CHANNEL
  • USER
  • ROLE
  • COMMAND

Commands

  • /credits
  • /changelog

Changed

  • The command and event handlers have been declassified (yes yes)
  • The bot will remove levels when an admin changed the leveling difficulty
  • /leaderboard shows 6 users per page instead of 5
  • When you add the bot, it sends a message in the system channel
  • Remade the message logs
    • Edit logs will let you jump to the message that got edited

/settings

  • Autocompletes with channels/users/roles (you don't have to copy IDs now 🎉)
  • In the embed it will show links to channels/users/roles instead of showing IDs

/about

  • Vote button added
  • Removed credits and put them in a different command to reduce the height of the embed

Fixed

News

  • Major issue related to the database, where the guild wasn't provided to ensure that news would be unique to every server, thank you @Golem642!!!!
  • /news edit's modal errored when sending

Moderation commands

  • /moderation clear removed one more message than the user provided
  • /moderation unban errored internally (it should send an error embed) when the user didn't have the "Ban Members" permission

Typos

  • "warn" mentions in /moderation warn are now "warning" to be more consistent
  • Removed old markdown remnants from /moderation slowdown

Left to do

Change

  • /settings command should show links to channels/users/roles, not IDs
  • The bot should remove levels when an admin changed the leveling difficulty. Example: user has 25574/27000 at level 10 and difficulty set to 2. The owner sets difficulty to 4. Level 10 requirement becomes 54000. 25574 is considered level 6, so user will be at level 6 instead of 10.

Fix

  • /news edit modal erroring
  • Interaction error in /settings when the bot sends an error about an inaccessible channel
  • Pretty mysterious /moderation unban error where there's seemingly no permission error embed sent.
  • This one hell of an issue below:
user@a:~/sokora$ bun start
$ bun ./src/index.ts
Launched shard 0
578 |    * @param method - The method of the request that erred
579 |    * @param url - The url of the request that erred
580 |    * @param bodyData - The unparsed data for the request that errored
581 |    */
582 |   constructor(rawError, code, status, method, url, bodyData) {
583 |     super(_DiscordAPIError.getMessage(rawError));
          ^
error: Cannot send messages to this user
 url: "https://discord.com/api/v10/channels/1307096732315947018/messages"
 code: "50007"

      at new DiscordAPIError (/home/user/sokora/node_modules/@discordjs/rest/dist/index.js:583:5)
      at /home/user/sokora/node_modules/@discordjs/rest/dist/index.js:727:13

Bun v1.1.34 (Linux arm64)

@MrSerge01 MrSerge01 mentioned this pull request Nov 28, 2024
45 tasks
@MrSerge01 MrSerge01 marked this pull request as ready for review November 29, 2024 19:07
Copy link
Contributor

@dimkauzh dimkauzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my request for about.ts, good to go!

src/commands/About.ts Outdated Show resolved Hide resolved
Copy link
Member

@Golem642 Golem642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is not ready to merge yet, I've still got to get back and review all of the news files.
Make sure to do the action before sending the modEmbed, and also let's not forget unnecessary console.log lol

src/commands/Leaderboard.ts Show resolved Hide resolved
src/commands/moderation/Ban.ts Show resolved Hide resolved
src/commands/moderation/Kick.ts Show resolved Hide resolved
src/commands/moderation/Mute.ts Show resolved Hide resolved
src/events/guildCreate.ts Outdated Show resolved Hide resolved
src/events/messageCreate.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@userandaname userandaname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine (i didnt check shit)

Copy link
Member

@Golem642 Golem642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make the changes and test them if i had my computer, but I'll only get it back tomorrow or so

src/commands/moderation/Ban.ts Show resolved Hide resolved
@MrSerge01 MrSerge01 changed the title 0.1.2 0.2.0 Dec 14, 2024
Copy link
Member

@Froxcey Froxcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to through this line by line, so I did a quick scan for nics
No problem found, LGTM ✧ദ്ദി( ˶^ᗜ^˶ )

vibe

@MrSerge01
Copy link
Member Author

ok here's the thing
golem's changes in moderation have to be fixed, not reverted
quick todo: re-revert golem's changes in moderation.ts and make it actually work
currently the issue is the fact that it doesn't increment the ID when it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants