Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rococo config deprecated #1331

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Remove rococo config deprecated #1331

merged 3 commits into from
Nov 15, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Nov 11, 2024

No description provided.

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this clean up!

@@ -698,7 +554,7 @@ export const SNOWBRIDGE_ENV: { [id: string]: SnowbridgeEnvironment } = {
BEACON_HTTP_API: "https://lodestar-sepolia.chainsafe.io",
ETHEREUM_API: (key) => `https://eth-sepolia.g.alchemy.com/v2/${key}`,
RELAY_CHAIN_URL: "https://westend-rpc.polkadot.io",
ASSET_HUB_URL: "wss://westend-asset-hub-rpc.polkadot.io",
ASSET_HUB_URL: "https://westend-asset-hub-rpc.polkadot.io",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break transfers, @polkadot/api has this weird issue where by it doesn't subscribe for finalization on transactions when using https. Using https means the code hangs forever waiting for an event that never comes.

If you want to use https override it when creating the context, see below for example.
https://github.com/Snowfork/snowbridge-app/blob/82a99e0aebe4146dd8b139780fbc788ab5405def/lib/snowbridge.ts#L222

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert in df25226

I change to https because met an issue today the monitor process fail to connect to AH through the WS endpoint, and it works with the https endpoint.

Anyway, we can still make WS default. It's also possible to overide the value with an env variable.

assetHub: process.env["ASSET_HUB_URL"] || config.ASSET_HUB_URL,

@yrong yrong requested a review from alistair-singh November 14, 2024 01:48
@yrong yrong merged commit 26fd3ac into main Nov 15, 2024
@yrong yrong deleted the ron/clean-config branch November 15, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants