Fix sibling location #1077
Fix sibling location #1077
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 55 55
Lines 2274 2274
Branches 71 71
=======================================
Hits 1835 1835
Misses 422 422
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| use xcm::v3::prelude::SendError as XcmSendError; | ||
| use xcm_builder::{DescribeAllTerminal, DescribeFamily, HashedDescription}; | ||
|
|
||
| pub type AgentIdOf = HashedDescription<H256, DescribeFamily<DescribeAllTerminal>>; | ||
| pub type AgentIdOf = HashedDescription<H256, (DescribeHere, DescribeFamily<DescribeAllTerminal>)>; |
There was a problem hiding this comment.
We're also repeating this line in the BridgeHub xcm_config.rs configuration, can you check?
In which case we should factor out both definitions into our parachain/runtime/runtime-common crate.
There was a problem hiding this comment.
Yeah, several duplications and refactoring with 8c1d1d8
Btw, prefer to move to primitives as it's very low level and not only used in runtime.
* Fix sibling location * Fix smoke test * Refactor AgentIdOf as primitive * Update sdk * Update sdk
Address for the comment paritytech/polkadot-sdk#2522 (comment)
Resolves: SNO-803