Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Group implied siblings (Type II) by parent #81

Closed
veradrawer opened this issue Aug 10, 2021 · 7 comments
Closed

FR: Group implied siblings (Type II) by parent #81

veradrawer opened this issue Aug 10, 2021 · 7 comments
Labels
FR New feature or request view:matrix Matrix View

Comments

@veradrawer
Copy link

I currently use parents, siblings and children as derivatives via the Matrix view: literary notes have as parent it's authors, and as implied children any notes that use said reference as bibliography. Siblings are thus any note that come from said parents, but I'ts missing the option to let us know wheresaid siblings are coming from.

It would be amazing to sort siblings by grouping them by parent: siblings by this parent, by the other one, and siblings by both. it would allow people to define in literary notes publishers or similar metadata without the fear of an innavigable bloat.

@veradrawer veradrawer changed the title Feature request: Collapsable siblings by parent Feature request: Group siblings by parent Aug 10, 2021
@SkepticMystic
Copy link
Owner

Interesting, I like this idea.
I'm gonna be working on a big change from some previous FRs, but I'll work on this when possible.

@SkepticMystic SkepticMystic added the FR New feature or request label Aug 11, 2021
@SkepticMystic
Copy link
Owner

@veradrawer I'm thinking about how this would be implemented. Everything would, of course, be optional. So there is no worry that it breaks functionality for users who don't want this feature.
That being said, there are a couple ways I'm thinking this could be done:

  1. If you hover over an implied note in the matrix view, there could be a tooltip showing which note implies it.
  2. There could be a more physical separation in the matrix view, with grid squares spacing out the implied relations based on the note that implied them:
    image

What are your thoughts on this? @HEmile, I see you are in favour of this feature too, what do you think?

@hieu6
Copy link

hieu6 commented Aug 18, 2021

I like option 2, physical/visual separation for a quick at a glance overview

@HEmile
Copy link
Collaborator

HEmile commented Aug 19, 2021

Yes, me too! Would it say what the parent is, though?

@SkepticMystic
Copy link
Owner

@HEmile Yes, the breadcrumbs would be grouped into a mini-matrix with the parent as it's heading

@SkepticMystic SkepticMystic added the view:matrix Matrix View label Sep 8, 2021
@SkepticMystic SkepticMystic changed the title Feature request: Group siblings by parent FR: Group implied siblings (Type II) by parent Nov 23, 2021
@SkepticMystic
Copy link
Owner

@veradrawer @hieu6 @HEmile I haven't implemented option 2 yet, but option 1 is working in the version I'm gonna release soon

SkepticMystic added a commit that referenced this issue Nov 29, 2021
@SkepticMystic SkepticMystic moved this to Todo in Breadcrumbs Mar 19, 2024
@SkepticMystic
Copy link
Owner

Now that there are so many different types of implied relations (and fully customisable ones, too), I don't think I'll add support for this. When there were only two types, it was reasonable to support grouping by the parent that implied the edge. But now that logic can't as easily be applied to all the possible kinds.
Let me know if you've got a different idea, but I'm gonna close this for now.
My recommendation is to use the latest "Sort" feature in the Matrix View, Tree View, and Codeblocks. You can sort by "Explicit", which will group real and implied edges together, and sub-group edges based on the Edge Builder that created them, and the Implied Relation that implied them

@SkepticMystic SkepticMystic closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Breadcrumbs Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR New feature or request view:matrix Matrix View
Projects
Status: Done
Development

No branches or pull requests

4 participants