Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-folder-note: Option for subfolders #218

Closed
chrisgrieser opened this issue Dec 18, 2021 · 11 comments
Closed

BC-folder-note: Option for subfolders #218

chrisgrieser opened this issue Dec 18, 2021 · 11 comments
Labels
builders Different methods for adding edges to the BC graph FR New feature or request

Comments

@chrisgrieser
Copy link
Contributor

I am trying to use a central note in a folder as parent for other files in that folder and it works great, however it seems that notes in subfolders are not supported.

How about an option to have BC-folder-note also include notes that are located in subfolders of the same folder?

@SkepticMystic
Copy link
Owner

Ooooohh interesting! Yeah, I like this idea.
I think the easiest is what you suggest. Even notes in subfolders are just made the child of the BC-folder-note.
A fancier option would be a nested thing where subfolders have their own folder-note that they point to, as those folder notes point to the main ones

@SkepticMystic SkepticMystic added builders Different methods for adding edges to the BC graph FR New feature or request labels Dec 18, 2021
@wychwitch
Copy link

I had JUST encountered this issue! I also would love this ^^

SkepticMystic added a commit that referenced this issue Jan 9, 2022
…subfolders of the folderNote and adds those notes, too (#218)
@SkepticMystic
Copy link
Owner

SkepticMystic commented Jan 9, 2022

@wychwitch @chrisgrieser @zhelding in the latest version, you can add BC-folder-note-subfolder: true to a folderNote to have the notes in subfolders of that folder note get added, too :)
Let me know if this is what you meant

@chrisgrieser
Copy link
Contributor Author

it works fine 🥳

But I was actually thinking targeting things only in a subfolder, for example to differentiate like this, which would actually reflect a lot of people's structure, I think?

BC-subfolder-note: down
BC-folder-note: same

@wychwitch
Copy link

wychwitch commented Jan 9, 2022

Ah yes, while this is very good and I can work with it, I agree with @chrisgrieser in that My folder set up isn't meshing perfectly with this

This is how my folder structure is set up

10 - Ash In The Snow ➜ 15 - Lore ➜ 15.02 - Theology ➜ The Different Types of Gods

Each folder with a preceding number is a folder with a folder note (of the same name), and the last one is the note itself!

What I would love is there to be a setting so subfolders with folder notes can be automatically assigned a child (or whatever kind of relationship you want) of the enclosing foldernote, without touching the non-folder notes within it.

Because right now, if I click on the file The Different Types of Gods, it will have a single link to 10 - Ash In The Snow, rather going up through the other two folder notes as expected

I hope this makes sense! If this is actually a configuration issue on my part, I'm sorry for wasting anyone's time hahaha

@zhelding
Copy link

zhelding commented Jan 9, 2022

Agreed with @wychwitch and @chrisgrieser that a "nesting" type option for sub-folders and their folder notes would be useful.

Essentially: my folders and sub-folders are already set up in a parent-child hierarchy nested multiple levels. It would be great to have that hierarchy reflected in Breadcrumbs.

@SkepticMystic
Copy link
Owner

Ok, I'm gonna work on this now.
The requirement for the nested-folder-note is that each subfolder along the way has to have a corresponding note with the exact same name as the folder

@SkepticMystic
Copy link
Owner

@chrisgrieser is this issue resolved with the addition of BC-folder-note-subfolder?

@chrisgrieser
Copy link
Contributor Author

yeah, from my end, you can check this off :)
(not gonna close this myself, since others might have a different opinion, but I doubt it)

@zhelding
Copy link

This is resolved in my opinion as well; thanks so much!

@wychwitch
Copy link

Me too!! hank you so much, its so seamless ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builders Different methods for adding edges to the BC graph FR New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants