fix: 🐛 Don't allow blank hierarchy fields

SkepticMystic · Nov 22, 2021 · 2a17ef9 · 2a17ef9
1 parent e4eebc6
commit 2a17ef9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/Components/UserHierarchies.svelte b/src/Components/UserHierarchies.svelte
@@ -93,7 +93,12 @@
             name={dir}
             value={hier[dir]?.join(", ") ?? ""}
             on:change={async (e) => {
-              currHiers[i][dir] = splitAndTrim(e.target.value);
+              const { value } = e.target;
+              if (value === "") {
+                currHiers[i][dir] = [];
+              } else {
+                currHiers[i][dir] = splitAndTrim(value);
+              }
               await update(currHiers);
             }}
           />

diff --git a/src/main.ts b/src/main.ts
@@ -970,6 +970,7 @@ export default class BCPlugin extends Plugin {
     const { limitTrailCheckboxStates, userHiers } = this.settings;
     const upFields = getFields(userHiers, "up");
     const downFields = getFields(userHiers, "down");
+
     let subGraph: MultiGraph;
 
     if (Object.values(limitTrailCheckboxStates).every((val) => val)) {
@@ -978,9 +979,9 @@ export default class BCPlugin extends Plugin {
       const positiveFields = Object.keys(limitTrailCheckboxStates).filter(
         (field) => limitTrailCheckboxStates[field]
       );
-      const oppFields = positiveFields.map(
-        (field) => getOppFields(userHiers, field)[0]
-      );
+      const oppFields = positiveFields
+        .map((field) => getOppFields(userHiers, field)[0])
+        .filter((field) => field !== undefined);
       subGraph = getSubForFields(this.mainG, [...positiveFields, ...oppFields]);
     }
 

diff --git a/src/sharedFunctions.ts b/src/sharedFunctions.ts
@@ -231,6 +231,7 @@ export function getReflexiveClosure(
   const copy = g.copy();
   copy.forEachEdge((k, a, s, t) => {
     const { dir, field } = a;
+    if (field === undefined) return;
     const oppDir = getOppDir(dir);
     const oppField = getOppFields(userHiers, field)[0];