Fix null ref exception in LookupType5Format2SubTable #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
| @@ -52,9 +52,9 @@ public IndicShaper(ScriptClass script, Tag unicodeScriptTag, TextOptions textOpt | |||
| { | |||
| this.textOptions = textOptions; | |||
|
|
|||
| if (IndicConfigurations.ContainsKey(script)) | |||
| if (IndicConfigurations.TryGetValue(script, out ShapingConfiguration value)) | |||
There was a problem hiding this comment.
.NET 7 CI now throws for ContainsKey
| @@ -528,12 +528,13 @@ or 0x2068 | |||
|
|
|||
| if (category != null) | |||
| { | |||
| if (!symbols.ContainsKey(category)) | |||
| if (!symbols.TryGetValue(category, out int value)) | |||
There was a problem hiding this comment.
.NET 7 CI now throws for ContainsKey
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
=====================================
Coverage 86% 86%
=====================================
Files 238 238
Lines 15182 15184 +2
Branches 2100 2101 +1
=====================================
+ Hits 13085 13088 +3
Misses 1613 1613
+ Partials 484 483 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tocsoft
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #364 cc @IshmaZX82