Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 355 #356

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix 355 #356

merged 2 commits into from
Sep 15, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #355

TR50 vertical codepoint substitution should only take place when the layout is not horizontal.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #356 (b10de71) into release/v1.x (b532dee) will increase coverage by 0%.
Report is 1 commits behind head on release/v1.x.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           release/v1.x    #356   +/-   ##
============================================
  Coverage            86%     86%           
============================================
  Files               238     238           
  Lines             15187   15189    +2     
  Branches           2110    2108    -2     
============================================
+ Hits              13071   13073    +2     
  Misses             1624    1624           
  Partials            492     492           
Flag Coverage Δ
unittests 86% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/SixLabors.Fonts/TextLayout.cs 86% <100%> (+<1%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit be8883c into release/v1.x Sep 15, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/v1-fix-355 branch September 15, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant