Bump Puppeteer to v23.2.1 and Chromium to v128 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaline
added a commit
that referenced
this pull request
Sep 5, 2024
Earlier Puppeteer/Chromium versions weren't phoning home to Google, but this appears to have changed after #145. This updates are proxy configuration to return 403s for any Google URLs which keeps them out of the test fixtures and makes things more predictable. A browser test has been added which verifies this behavior. Connects #145 Merges #150 LGTM given by: @KPreisner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps Puppeteer for the browser tests from v22.6.0 to v23.2.1 and Chromium from v123 to v128. The docker development image on ARM requires pulling in an ARM Chromium build from a third-party source (Microsoft Playwright), and this was updated to r1129 which provides Chromium v128.0.6613.18. This differs slightly from the v128.0.6613.86 version bundled with Puppeteer, but it's not consequential. Minor version mismatches don't really matter for what we're doing here, but it's good to keep them as close as possible.
For future reference:
Connects #98