worker: set up child Isolate inside Worker thread

Refs: nodejs#24016 PR-URL: nodejs#26011 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
SimenB · Feb 11, 2019 · 5bc6e49 · 5bc6e49
1 parent 58ba8bf
commit 5bc6e49
Show file tree

Hide file tree

Showing 4 changed files with 201 additions and 172 deletions.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -885,12 +885,14 @@ bool Agent::IsActive() {
   return io_ != nullptr || client_->IsActive();
 }
 
-void Agent::AddWorkerInspector(int thread_id,
-                               const std::string& url,
-                               Agent* agent) {
-  CHECK_NOT_NULL(client_);
-  agent->parent_handle_ =
-      client_->getWorkerManager()->NewParentHandle(thread_id, url);
+void Agent::SetParentHandle(
+    std::unique_ptr<ParentInspectorHandle> parent_handle) {
+  parent_handle_ = std::move(parent_handle);
+}
+
+std::unique_ptr<ParentInspectorHandle> Agent::GetParentHandle(
+    int thread_id, const std::string& url) {
+  return client_->getWorkerManager()->NewParentHandle(thread_id, url);
 }
 
 void Agent::WaitForConnect() {

diff --git a/src/inspector_agent.h b/src/inspector_agent.h
@@ -85,7 +85,9 @@ class Agent {
   void EnableAsyncHook();
   void DisableAsyncHook();
 
-  void AddWorkerInspector(int thread_id, const std::string& url, Agent* agent);
+  void SetParentHandle(std::unique_ptr<ParentInspectorHandle> parent_handle);
+  std::unique_ptr<ParentInspectorHandle> GetParentHandle(
+      int thread_id, const std::string& url);
 
   // Called to create inspector sessions that can be used from the main thread.
   // The inspector responds by using the delegate to send messages back.