Use playwright instead of requests for browse #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unnecessary files
nponeccop
previously requested changes
Apr 9, 2023
.gitignore
Outdated
There was a problem hiding this comment.
Submit this change as a separate PR. PRs should be atomic, not mixing unrelated changes together.
requirements.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| beautifulsoup4 | |||
| colorama==0.4.6 | |||
| dirtyjson==1.0. | |||
There was a problem hiding this comment.
Why? It is unrelated to the Playwrite replacements. Separate PR. Even if it was related, delete, not comment.
requirements.txt
Outdated
| @@ -9,5 +9,5 @@ readability-lxml==0.8.1 | |||
| requests | |||
| tiktoken==0.3.3 | |||
| docker | |||
| # googlesearch-python | |||
There was a problem hiding this comment.
Pinning down a dependency is unrelated. Put to a separate PR.
scripts/json_parser.py
Outdated
There was a problem hiding this comment.
Using JSON instead of Dirty JSON should be either in a separate PR or documented in the description of this PR as for why it is important
|
@ryanmac Resolve the conflicts |
|
Looks good for the most part if you do decide to update this move to commands/ and remove duplicate functions please. |
BillSchumacher
approved these changes
Apr 15, 2023
tgonzales
pushed a commit
to tgonzales/Auto-GPT
that referenced
this pull request
Apr 19, 2023
…_interfaces_and_types feat: add interfaces, types and constants file
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…owser Use playwright instead of requests for browse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch out the browse feature with Playwright. Many sites do not work with
requests. Playwright imitates the browser better.This also adds a new requirement for install:
This also includes:
auto_gpt_workspace/*in.gitignore