Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap context menu for dropdown to fix three dots doing nothing #9091

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Dec 20, 2024

Changes πŸ—οΈ

swaps context menu for dropdown menu

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@ntindle ntindle requested a review from a team as a code owner December 20, 2024 04:35
@ntindle ntindle requested review from Bentlybro and kcze and removed request for a team December 20, 2024 04:35
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

UI Accessibility
Verify that the dropdown menu is keyboard accessible and follows ARIA best practices for dropdown menus

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 2cc69ae
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6764f42e7473580008f5c719

Copy link

netlify bot commented Dec 20, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 2cc69ae
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6764f42e29cd93000896d01b
😎 Deploy Preview https://deploy-preview-9091--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Swiftyos Swiftyos merged commit ddac69e into dev Dec 20, 2024
20 checks passed
@Swiftyos Swiftyos deleted the ntindle/open-2255-clicking-the-3-dots-in-the-agent-dashboard-does-nothing branch December 20, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 1 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants