Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): Make username case insensitive #9088

Merged

Conversation

Swiftyos
Copy link
Contributor

Username was case sensitive, made username case insensitive

@Swiftyos Swiftyos requested a review from a team as a code owner December 19, 2024 17:23
@Swiftyos Swiftyos requested review from ntindle and kcze and removed request for a team December 19, 2024 17:23
@github-actions github-actions bot added size/m platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end and removed size/m labels Dec 19, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Data Consistency
Existing usernames in the database may need to be migrated to lowercase to maintain consistency with the new case-insensitive approach

Error Handling
The new profile creation code returns profile details directly without checking if the creation was successful

Code Order
The similarAgents query uses agent.categories[0] before agent is defined in the code flow

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit d249b6e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/676456a737799b000810479b

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit d249b6e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/676456a77516e40008656eba
😎 Deploy Preview https://deploy-preview-9088--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Swiftyos Swiftyos enabled auto-merge December 19, 2024 17:25
@Swiftyos Swiftyos added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit ca91754 Dec 19, 2024
22 checks passed
@Swiftyos Swiftyos deleted the swiftyos/open-2259-make-creator-username-case-insensitive branch December 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants