Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend) Remove "credentials" from export & import of agents #9081

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Bentlybro
Copy link
Member

@Bentlybro Bentlybro commented Dec 19, 2024

Changes 🏗️

This is for Credential ID Exports into Agent JSON #8919

I have added a new function removeCredentials into utils.ts which will go through and look for any "credentials" that are in the JSON during a agent export, this will then remove them and let the user download the file.

I have also added the same function to the importing of agents for old agents that where exported that still contain the credentials, this means that old agents can be imported with out breaking/causing issues.

When I say it looks for credentials I dont mean actual credentials like api keys them self, in the JSON that is exported it contains the following, this needs removing

"credentials": {
  "id": "6767232a-3407-4c34-85a3-6887d4969f0c",
  "title": "Anthropic Toran",
  "provider": "anthropic",
  "type": "api_key"
},

If there is a better way to go about this let me know!

@Bentlybro Bentlybro requested a review from a team as a code owner December 19, 2024 13:03
@Bentlybro Bentlybro requested review from Pwuts and kcze and removed request for a team December 19, 2024 13:03
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit a8dadbd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67641a8e647f3200087fd5b3

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit a8dadbd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67641a8e89715d00088a4bc2

Copy link
Contributor

@Swiftyos Swiftyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea

@Bentlybro Bentlybro added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit 4f15da9 Dec 19, 2024
20 checks passed
@Bentlybro Bentlybro deleted the bently/open-2153-credential-id-exports-into-agent-json branch December 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants