Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): Uploading to store selects two agents #9065

Merged

Conversation

Swiftyos
Copy link
Contributor

Fixes #9059

Changes πŸ—οΈ

  • Changed agent selection from keying on agent name to keying on agent id

@Swiftyos Swiftyos requested a review from a team as a code owner December 19, 2024 08:36
@Swiftyos Swiftyos requested review from Pwuts and kcze and removed request for a team December 19, 2024 08:36
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 19, 2024
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis βœ…

9059 - Fully compliant

Compliant requirements:

  • Fixed agent selection by changing from agent name to agent id based selection
⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Code Validation
Verify that agent.id is always available and unique across all agents to prevent duplicate selections

Copy link

netlify bot commented Dec 19, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit c985295
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6763db045d7af40008e93cce

Copy link

netlify bot commented Dec 19, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit c985295
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6763db0409b5580008c72af0
😎 Deploy Preview https://deploy-preview-9065--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Torantulino Torantulino added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit 4646de4 Dec 19, 2024
20 checks passed
@Torantulino Torantulino deleted the swiftyos/open-2243-uploading-to-store-selects-two-agents branch December 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/s
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants