Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(frontend): additional build page automation tooling #8951

Merged
merged 7 commits into from
Dec 17, 2024
Merged

test(frontend): additional build page automation tooling #8951

merged 7 commits into from
Dec 17, 2024
+110 −5

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Dec 11, 2024 •
edited
Loading

The tutorial was a bit harder than we expected to completely automate. Along the way though, we made these functions so lets keep em in for future use

Changes 🏗️

  • Adds a few more functions for the build automation pages

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan: Writing tests

@ntindle
feat: partial tutorial
30d5df0 
the final connecting two blocks doesn't work yet
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 11, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 238e4d2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/675bdba1be73590008daf6ec

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 238e4d2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/675bdba12dffa900086f146c

@ntindle ntindle changed the title feat: tutorial automation feat: additional build page automation tooling Dec 12, 2024
@ntindle ntindle marked this pull request as ready for review December 12, 2024 17:51
@ntindle ntindle requested a review from a team as a code owner December 12, 2024 17:51
@ntindle ntindle requested review from Pwuts and Bentlybro and removed request for a team December 12, 2024 17:51
@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Untested Code
The getBlocksInAgent() method is marked as untested and throws an error. This should be properly implemented and tested before merging.

Error Handling
The moveBlockToSide() method lacks error handling for edge cases like invalid transforms or DOM element not found scenarios.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Dec 16, 2024
@Pwuts Pwuts changed the title feat: additional build page automation tooling feat(frontend): additional build page automation tooling Dec 17, 2024
@Pwuts Pwuts changed the title feat(frontend): additional build page automation tooling test(frontend): additional build page automation tooling Dec 17, 2024
@Swiftyos Swiftyos added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit abd245c Dec 17, 2024
21 checks passed
@Swiftyos Swiftyos deleted the ntindle/open-2097-integration-test-complete-the-tutorial branch December 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftyos Swiftyos Swiftyos approved these changes

@Pwuts Pwuts Awaiting requested review from Pwuts Pwuts is a code owner automatically assigned from Significant-Gravitas/maintainers

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/l
Projects
Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntindle @Swiftyos