Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Make pins smaller and fix hover area and highlight for input pins #8941

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Dec 11, 2024

Recently pins were made slightly bigger and misaligned needlessly. The problem in the linked issue was to fix connection area, not make them bigger.

Changes 🏗️

  • Revert pins size to smaller
  • Fix hover area and highlight for input pins

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Connect, reconnect, remove connection
    • Tutorial works
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@kcze kcze requested a review from a team as a code owner December 11, 2024 07:24
@kcze kcze requested review from aarushik93 and majdyz and removed request for a team December 11, 2024 07:24
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 379d225
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67594c0e60821700085c1368

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 379d225
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67594c0e1db9bc0008fe8d15

@kcze kcze marked this pull request as draft December 11, 2024 08:01
@github-actions github-actions bot added size/m and removed size/s labels Dec 11, 2024
@kcze kcze marked this pull request as ready for review December 11, 2024 08:24
@kcze kcze changed the title fix(frontend): Make pins smaller and fix hover highlight for input pins fix(frontend): Make pins smaller and fix hover area and highlight for input pins Dec 11, 2024
Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, thank you for this :)

@kcze kcze added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 7a9115d Dec 11, 2024
19 checks passed
@kcze kcze deleted the kpczerwinski/open-2148-connection-pins-area-is-too-small branch December 11, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants